style(settings): General style updates - Githubissues

mozilla / fxa

Monorepo for Mozilla Accounts (formerly Firefox Accounts)

https://mozilla.github.io/ecosystem-platform/

Mozilla Public License 2.0

602 stars 210 forks source link

style(settings): General style updates #18020

Closed vpomerleau closed 1 week ago

vpomerleau commented 1 week ago

Because

Switching design to text-start default instead of text-center
Some images were cut off on mobile

This pull request

Update style for AppLayout
Update image styling
Various tweaks to accommodate change to text-start
Set size for Mozilla logo in Storybook sidebar
Replace placeholder image used in storybooks (placekitten server no longer seems to work)
Adjust padding for data block, third party auth buttons
Fix error banner shown instead of success banner on inline 2FA setup

Issue that this pull request solves

Closes: #FXA-10613, FXA-10741

Checklist

Put an x in the boxes that apply

[x] My commit is GPG signed.
[x] If applicable, I have modified or added tests which pass locally.
[x] I have added necessary documentation (if appropriate).
[x] I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Start align and image fix on mobile:

Signin (with start text align) - opted to leave email centered with avatar

Signup (sync) with text-start

Other information (Optional)

Opted to keep content centered on a few select screens:

Legal:

Confirmation pages that only contained a heading, centered image and one-liner text or CTA. E.g.,