search

mozilla / lightbeam

Orignal unmaintained version of the Lightbeam extension. See lightbeam-we for the new one which works in modern versions of Firefox.
https://github.com/mozilla/lightbeam-we
Mozilla Public License 2.0
586 stars 149 forks source link

List view is broken #637

Closed fmarier closed 9 years ago

fmarier commented 9 years ago

It looks like the scrollbar in the list view is broken / missing.

lightbeam-no-scrollbars

fmarier commented 9 years ago

Also, the buttons at the bottom of the screen are no longer visible.

ghost commented 9 years ago

Same here, site preferences seems to get pushed off screen at the bottom (you can just see it at the bottom of the screen shot) site pref

cookiefirewall commented 9 years ago

Mine is doing the same thing it stopped working for me. kept getting doubleclick.net running on everything disabled the ip address with a firewall to block it worked for about 3 months then the buttons and scroll are gone

cookiefirewall commented 9 years ago

wish you guys with get with cisco on this and take it to a enterprise level.. technology has reached a point where they need a firewall that runs like this and can smart user control

cookiefirewall commented 9 years ago

but my block unblock and scroll are gone

cookiefirewall commented 9 years ago

dont forget to block adapt.tv when you see I assume it was changing my tv guide on my dvr and removing items some kind of bug because when I blocked it all my foot ball games and simpsons came back cant wait for superbowl to see if it freezes when I firewalled adapt.tv it this year

Caerolusmagnus commented 9 years ago

I have similar problem to fmarier. The list will not scroll down and so I cannot use any block function since it is below the screen.

myppka commented 9 years ago

Same thing here. Let me know how to fix it, because I need to UNBLOCK a site I need now.

Caerolusmagnus commented 9 years ago

I have just checked and the Lightbeam is still non-scrolling on the List and so is non-functional. Also in early days I could select a site and a detailed description of the specific site, location, origin, purpose could be opened.That function disappeared months ago. An once-excellent site is shrinking to just useless.

On 17/12/2014, myppka notifications@github.com wrote:

Same thing here. Let me know how to fix it, because I need to UNBLOCK a site I need now.

Reply to this email directly or view it on GitHub: https://github.com/mozilla/lightbeam/issues/637#issuecomment-67315445

* Charles McGrory 31 Tabard Road Glasgow G13 3XE Scotland

fmarier commented 9 years ago

Just making a note that the UI works fine in Firefox 31 and is broken in 34.

Caerolusmagnus commented 9 years ago

Thank you. I have re-installed Mozilla 31 displacing 34 etc and the Lightbeam has come back with the functions. Excellent.

On 20/12/2014, Francois Marier notifications@github.com wrote:

Just making a note that the UI works fine in Firefox 31 and is broken in 34.

Reply to this email directly or view it on GitHub: https://github.com/mozilla/lightbeam/issues/637#issuecomment-67754362

* Charles McGrory 31 Tabard Road Glasgow G13 3XE Scotland

fmarier commented 9 years ago

I'm currently bisecting mozilla-central:

214481:c06d3c3cac32 bad
...
198563:8e80d6b6f9af bad
...
197006:479cbe3d30cd bad
...
196192:aa538ad2d73e bad
...
195815:5b0c799f15bf bad
...
195580:24f3cfb76bf0 bad
...
195494:e5ced39f443b good
...
195315:c7872ffb3adc good
fmarier commented 9 years ago

Here are the results of the bisect:

$ hg bisect --bad 214481:c06d3c3cac32
$ hg bisect --good 195315:c7872ffb3adc
...
The first bad revision is:
changeset:   195526:e740a64c284b
parent:      195494:e5ced39f443b
parent:      195525:4d5d939010e5
user:        Ed Morley <emorley@mozilla.com>
date:        Tue Jul 22 17:30:16 2014 +0100
summary:     Merge mozilla-central and inbound

Not all ancestors of this changeset have been checked.
Use bisect --extend to continue the bisection from
the common ancestor, f5f5cad240b3.

$ hg bisect --extend
...
The first bad revision is:
changeset:   195505:24c2f03786ac
user:        Daniel Holbert <dholbert@cs.stanford.edu>
date:        Tue Jul 22 08:24:35 2014 -0700
summary:     Bug 984711 part 5: Add back handling for min-height:auto to nsFlexContainerFrame. r=mats

In other words, this appears to be the commit that broke the Lightbeam UI: https://hg.mozilla.org/mozilla-central/rev/24c2f03786ac

Caerolusmagnus commented 9 years ago

Thanks for update I had replaced with Firefox 31. Lightbeam worked then did not for Firefox 34 automatically replaced it. So I reloaded Firefox 31 and stopped the automatic update.

On 23/12/2014, Francois Marier notifications@github.com wrote:

Here are the results of the bisect:

$ hg bisect --bad 214481:c06d3c3cac32
$ hg bisect --good 195315:c7872ffb3adc
...
The first bad revision is:
changeset:   195526:e740a64c284b
parent:      195494:e5ced39f443b
parent:      195525:4d5d939010e5
user:        Ed Morley <emorley@mozilla.com>
date:        Tue Jul 22 17:30:16 2014 +0100
summary:     Merge mozilla-central and inbound

Not all ancestors of this changeset have been checked.
Use bisect --extend to continue the bisection from
the common ancestor, f5f5cad240b3.

$ hg bisect --extend
...
The first bad revision is:
changeset:   195505:24c2f03786ac
user:        Daniel Holbert <dholbert@cs.stanford.edu>
date:        Tue Jul 22 08:24:35 2014 -0700
summary:     Bug 984711 part 5: Add back handling for min-height:auto to

nsFlexContainerFrame. r=mats

In other words, this appears to be the commit that broke the Lightbeam UI: https://hg.mozilla.org/mozilla-central/rev/24c2f03786ac

Reply to this email directly or view it on GitHub: https://github.com/mozilla/lightbeam/issues/637#issuecomment-67929144

* Charles McGrory 31 Tabard Road Glasgow G13 3XE Scotland

fmarier commented 9 years ago

@Caerolusmagnus if you want to use Firefox 31 until Lightbeam is fixed, please use the version from https://www.mozilla.org/en-US/firefox/organizations/, that's a supported version of 31 so you can enable auto-updates and it won't upgrade you to 34.

Disabling auto-updates is generally not a good idea because it means you're not getting security updates anymore.

fmarier commented 9 years ago

@monicachew points out that the offending commit is also part of what broke the graph in #622.

Caerolusmagnus commented 9 years ago

i have reinstalled Firefox 31 and blocked any auto update of Firefox 34... This has allowed the scrolling and blocking functions again.

I appreciate the comments I have been receiving.

Here is another function that got lost. In the early days of Lightbeam there was a function to select a third party site and click to display the identity and purpose of the site. This enabled the decision to block or not block. This identification function disappeared some months ago. It was very useful.

Perhaps someone can provide a method to reinstall such a good site interrogation function. Thanks.

On 23/12/2014, Francois Marier notifications@github.com wrote:

@monicachew points out that the offending commit is also part of what broke the graph in #622.

Reply to this email directly or view it on GitHub: https://github.com/mozilla/lightbeam/issues/637#issuecomment-68010433

* Charles McGrory 31 Tabard Road Glasgow G13 3XE Scotland

fmarier commented 9 years ago

Fixed by #640.

Caerolusmagnus commented 9 years ago

Sounds good. I will try latest Firefox again. If still a problem I will go back to Firefox 31. Thanks.

On 07/01/2015, Francois Marier notifications@github.com wrote:

Fixed by #640.

Reply to this email directly or view it on GitHub: https://github.com/mozilla/lightbeam/issues/637#issuecomment-68977033

* Charles McGrory 31 Tabard Road Glasgow G13 3XE Scotland

fmarier commented 9 years ago

@Caerolusmagnus You'll need to upgrade to Lightbeam 1.1.1 first, which isn't yet released. It should be done this week though.

Also, don't forget to re-enable automatic updates after you move back to Firefox 34 :)

Caerolusmagnus commented 9 years ago

Very good advice. I will wait for Lightbeam upgrade and confirm. Thank you!

On 07/01/2015, Francois Marier notifications@github.com wrote:

@Caerolusmagnus You'll need to upgrade to Lightbeam 1.1.1 first, which isn't yet released. It should be done this week though.

Also, don't forget to re-enable automatic updates after you move back to Firefox 34 :)

Reply to this email directly or view it on GitHub: https://github.com/mozilla/lightbeam/issues/637#issuecomment-68984388

* Charles McGrory 31 Tabard Road Glasgow G13 3XE Scotland

fmarier commented 9 years ago

Version 1.1.1 is now available on https://addons.mozilla.org/en-US/firefox/addon/lightbeam/

Caerolusmagnus commented 9 years ago

Thank you. I have downloaded version 1.1.1 and look forward to good performance hereon. I will install Firefox 34... and see what happens, Thanks again for your kind attention.

On 07/01/2015, Francois Marier notifications@github.com wrote:

Version 1.1.1 is now available on https://addons.mozilla.org/en-US/firefox/addon/lightbeam/

Reply to this email directly or view it on GitHub: https://github.com/mozilla/lightbeam/issues/637#issuecomment-69111671

* Charles McGrory 31 Tabard Road Glasgow G13 3XE Scotland