search

mozilla / m-response

Crowdsourcing Mozilla responses to Google Play Store reviews
Mozilla Public License 2.0
12 stars 10 forks source link

Permission restriction per locale #538

Closed kelimuttu closed 4 years ago

kelimuttu commented 4 years ago

Mod1 and mod2 access right now are not restricted to a specific locale. Someone with mod2 access can bypass any moderation for any locales. This should be changed so a moderator can be restricted to a certain locale.

LeoMcA commented 4 years ago

Since https://github.com/mozilla/sumo-project/issues/514 mod2s should be slightly restricted in locales they don't have permissions in. When they post in such a locale, they'll be treated as if they were a mod1 (so review skips community moderation, but doesn't get submitted).

Do you have an example of a mod2 skipping staff approval as well in a locale they shouldn't?

kelimuttu commented 4 years ago

got it. In that case, can we add multiple locale permission?

LeoMcA commented 4 years ago

multiple locale permission

What do you mean by this? Users can already be made mod2 in multiple locales

kelimuttu commented 4 years ago

Just to clarify,

What I mean is, for example, say I want to be an English and Japanese mod2. Will my mod2 permission restricted to those 2 locales?

LeoMcA commented 4 years ago

Yes, it can be - the "Permissions in locales" field sets which of the user's locales they'll have mod2 permission in, they'll have mod1 in every other locale. So if a user has declared their locales to be en, jp and de, and you set their "permissions in locales" to be "en,jp" they'll be mod2 in en and jp and mod1 in de.

kelimuttu commented 4 years ago

Aah, got it. Thanks for clarifying. I think this should be closed, then.