search

mozilla / makerstrap

A bootstrap extension for Webmaker
http://mozilla.github.io/makerstrap/demo
21 stars 22 forks source link

Skin alerts component #8

Closed k88hudson closed 10 years ago

k88hudson commented 10 years ago

http://getbootstrap.com/components/#alerts

image

We need to make this more Webmaker-appropriate

k88hudson commented 10 years ago

@mlveis is going to implement this but it needs some design/comps before it goes ahead. Can you help with that @cassiemc?

cassiemc commented 10 years ago

alerts-3 Here's a design for these – using font-awesome icons for all (except "Heads up" which is icon-less), Open Sans bold & regular, and colours from the palette. Let me know if you have any questions about this @mlveis.

k88hudson commented 10 years ago

@mlveis A few comments in the PR, this is almost there!

k88hudson commented 10 years ago

Can you also edit the existing alerts in the demo to use .alert .alert-info and add the .alert-link class to the links in them? Thanks!

image image

mlveis commented 10 years ago

@k88hudson thanks for the comments, I will make the required changes.

k88hudson commented 10 years ago

Ok, your PR is R+ -- squash those commits, and we can land it on master