mozilla / ping-centre

INACTIVE - http://mzl.la/ghe-archive
Mozilla Public License 2.0
8 stars 10 forks source link

Consider removing the 'config' package #37

Closed jaredhirsch closed 7 years ago

jaredhirsch commented 7 years ago

It looks like ping-centre is using node-config to grab the 'endpoint' config value, based on NODE_ENV.

Unfortunately, the node-config package causes problems with an ES6 build chain, because it uses conditional requires, and those are explicitly disallowed in ES6.

I'm not sure what the best option is here. Maybe another library? Maybe try to get the node-config fix landed?