search

mozilla / releasewarrior

Similar to the definition of a Census, this tool systematically acuires and records information about the releases of a given product
9 stars 16 forks source link

Fix when checkbox is not provided in command line #65

Closed JohanLorenzo closed 7 years ago

JohanLorenzo commented 7 years ago

Follow up #62

STR: releasewarrior update --issue 'my issue' firefox release 1.2.3

Results:

Traceback (most recent call last):
  File "/home/jlorenzo/.virtualenvs/releasewarrior/bin/release", line 11, in <module>
    load_entry_point('releasewarrior', 'console_scripts', 'release')()
  File "/home/jlorenzo/git/mozilla/releasewarrior/releasewarrior/__main__.py", line 132, in main
    args.command(args).run()  # <3 argparse for this
  File "/home/jlorenzo/git/mozilla/releasewarrior/releasewarrior/commands.py", line 190, in __init__
    self.changes = get_update_data(args)
  File "/home/jlorenzo/git/mozilla/releasewarrior/releasewarrior/helpers.py", line 86, in get_update_data
    _get_checkbox_value("submitted_shipit", args, args.submitted_shipit),
  File "/home/jlorenzo/git/mozilla/releasewarrior/releasewarrior/helpers.py", line 73, in _get_checkbox_value
    if alias in args.checkboxes:
TypeError: argument of type 'NoneType' is not iterable
rail commented 7 years ago

I hit the same thing yesterday, when tried to call it with --graphid. Worked around with passing --checkbox shipit --graphid xxxx.