ES2015 Object.assign doesn't copy over (own) symbol properties

mozilla / rhino

Rhino is an open-source implementation of JavaScript written entirely in Java

https://rhino.github.io

Other

4.19k stars 852 forks source link

ES2015 Object.assign doesn't copy over (own) symbol properties #1391

Open p-bakker opened 1 year ago

p-bakker commented 1 year ago

Pretty much as the title says

rbri commented 1 year ago

I guess this is not that hard to fix. @p-bakker do you like to create some unit test is org.mozilla.javascript.tests.es6.NativeObjectTest for that?

p-bakker commented 1 year ago

Do we need our own UnitTest for this, as Test262 already covers this via https://github.com/tc39/test262/blob/f94fc660cc3c59b1f2f9f122fc4d44b4434b935c/test/built-ins/Object/assign/strings-and-symbol-order.js?

rbri commented 1 year ago

At least i prefer to write a unit test to have a really isolated case for implementing and debugging. The 262 tests are usually monsters testing many different things in one case.