mpalourdio / ng-http-loader

:dango: Smart angular HTTP interceptor - Intercepts automagically HTTP requests and shows a spinkit spinner / loader / progress bar
MIT License
352 stars 65 forks source link

MatSpinner not showing after Angular Update 13.2.6 #169

Closed Arghh closed 2 years ago

Arghh commented 2 years ago

Expected behavior

MatSpinner animation is shown as own Spinner

Actual behavior

Ng-Http-Loader is working and the Browser is blocked, while an http-request is running so ng-http-loader works fine. The Spinner is not shown. When I change the [entryComponent]="matSpinner" to [spinner]="spinkit.skWave" the Spinner is shown. So it is a Problem with [entryComponent] or the { MatSpinner } from '@angular/material/progress-spinner';

Steps to reproduce

After updating from Angular 13.2.0 to 13.2.6 the MatSpinner is not been shown. I add <ng-http-loader [entryComponent]="matSpinner"> and in my Component I have MatSpinner defined as matSpinner = MatSpinner; from import { MatSpinner } from '@angular/material/progress-spinner';

It works fine with Angular VErsion (Material Version also 13.2.0) 13.2.0, but after the Update to 13.2.6 Angular/Material the Spinner https://material.angular.io/components/progress-spinner/overview is not been showing after the update.

ng-http-loader version

11.0.1

mpalourdio commented 2 years ago

Thanks for reporting this. Looks more like a bug in angular or material than here. Have you tested with the fresh 13.3.0 release ?

Arghh commented 2 years ago

I tried angular 13.3.0 same result. I did managed to get it working creating an extra component. "custom-spinner.component.ts" (empty) and template custom-spinner.component.html with just tag.

then I changed [entryComponent]="matSpinner" to [entryComponent]="customSpinnerComponent" so I needed an extra template with mat-spinner html-tag and can't call matSpinner from import { MatSpinner } from '@angular/material/progress-spinner direkt in the ng-http-loader tag.

I'm ok with this workaround and you can close the issue.

mpalourdio commented 2 years ago

Thanks for feedback.Closing now.