mpc-qt / mpc-qt

Media Player Classic Qute Theater
https://mpc-qt.github.io
GNU General Public License v2.0
609 stars 40 forks source link

Crash when hovering over seek bar with Wayland & Show video preview enabled #435

Closed r2rX closed 1 month ago

r2rX commented 1 month ago

Hello there,

As the title informs, mpc-qt immediately crashes/closes the moment the mouse hovers over the seek bar when both 'Prefer Wayland over XWayland' and 'Show video preview' are enabled. For now, those on Wayland either have to disable the video preview feature or stick with XWayland if they want to use it.

Tested with self-compiled build (Based on Qt 6.9.0 and mpv v0.40.0, v24.12-master-357-ga43505d).

Operating System: Fedora Linux 42 KDE Plasma Version: 6.3.5 KDE Frameworks Version: 6.14.0 Qt Version: 6.9.0 Kernel Version: 6.14.5-300.fc42.x86_64 (64-bit) Graphics Platform: Wayland Processors: 16 × AMD Ryzen 9 5900HX with Radeon Graphics Memory: 30.7 GiB of RAM Graphics Processor 1: AMD Radeon RX 6800M Graphics Processor 2: AMD Radeon Graphics Manufacturer: ASUSTeK COMPUTER INC. Product Name: ROG Strix G513QY_G513QY System Version: 1.0

tbertels commented 1 month ago

Thanks for the report! Unfortunately, it doesn't seem possible right now to make the video preview follow the mouse pointer, so it doesn't work as well as with X11 or XWayland.

r2rX commented 1 month ago

Cheers for the prompt response!

Can I assume that the inability for the video preview to follow the mouse pointer being related to the Wayland protocol/implementation? Will this need work, on Wayland itself, to get working down the line?

r2rX commented 1 month ago

Just wanted to give feedback that it's no longer crashing when both Wayland and video preview are enabled. It is behaving as you described in #438, @tbertels, where the preview window is centered in the main window.

tbertels commented 1 month ago

https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/264 would make it move correctly. But that wouldn't make the video preview work on Windows in fullscreen obviously.

r2rX commented 1 month ago

https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/264 would make it move correctly. But that wouldn't make the video preview work on Windows in fullscreen obviously.

So this would resolve the video preview in Linux, both windowed and fullscreen, but would break it in fullscreen on Windows?

tbertels commented 4 weeks ago

https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/264 would make it move correctly. But that wouldn't make the video preview work on Windows in fullscreen obviously.

So this would resolve the video preview in Linux, both windowed and fullscreen, but would break it in fullscreen on Windows?

No, it's already broken on Windows in fullscreen (like tooltips) and this wouldn't have any impact.

r2rX commented 4 weeks ago

Ah. That makes better sense now. I don't use Windows so I didn't know the quirks of mpc-qt on it.