search

mpdeimos / gnome-shell-remove-dropdown-arrows

Removes the dropdown arrows from the AppMenu and SystemMenu (AggregateMenu) which were introduced in Gnome 3.10.
https://extensions.gnome.org/extension/800/remove-dropdown-arrows/
GNU General Public License v3.0
52 stars 11 forks source link

not working anymore on Gnome 3.22.2 / Debian 9.6 #10

Closed DanScharon closed 5 years ago

DanScharon commented 5 years ago

after the recent update, an error is thrown upon activation

dmke commented 5 years ago

Same here. In /var/log/messages, these lines appear after upgrading/installing the latest version:

Jan 25 16:17:10 dm org.gnome.Shell.desktop[2033]: Archive:  /tmp/UG30VZ.shell-extension.zip
Jan 25 16:17:10 dm org.gnome.Shell.desktop[2033]:   inflating: /home/dm/.local/share/gnome-shell/extensions/remove-dropdown-arrows@mpdeimos.com/README.md
Jan 25 16:17:10 dm org.gnome.Shell.desktop[2033]:   inflating: /home/dm/.local/share/gnome-shell/extensions/remove-dropdown-arrows@mpdeimos.com/extension.js
Jan 25 16:17:10 dm org.gnome.Shell.desktop[2033]:   inflating: /home/dm/.local/share/gnome-shell/extensions/remove-dropdown-arrows@mpdeimos.com/LICENSE
Jan 25 16:17:10 dm org.gnome.Shell.desktop[2033]:  extracting: /home/dm/.local/share/gnome-shell/extensions/remove-dropdown-arrows@mpdeimos.com/metadata.json
Jan 25 16:17:10 dm gnome-shell[2033]: JS LOG: Extension "remove-dropdown-arrows@mpdeimos.com" had error: TypeError: children.map(...).includes is not a function
dmke commented 5 years ago

These seem to be the culprit(s):

N.B., these are equivalent:

foo.includes(bar)
foo.indexOf(bar) >= 0
mpdeimos commented 5 years ago

I don't have a 3.22 test env, so I'm not sure if this is the only incompatibility.

Does the extension work again if you replace includes w/ indexOf?

dmke commented 5 years ago

Yes, the extension works fine after replacing the two occurrences of the includes function.

mpdeimos commented 5 years ago

Thanks for testing. Drafted a new release and pushed it to GSE website.