search

mperrin / poppy

Physical Optics Propagation in Python
BSD 3-Clause "New" or "Revised" License
173 stars 40 forks source link

API inconsistency in specifying shifts between FITS and Analytic optics #247

Closed mperrin closed 5 years ago

mperrin commented 6 years ago

How it works now: a = FITSOpticalElement(shift=(X,Y)) but b = AnalyticOpticalElement(shift_x=X, shift_y=Y)

This is inelegant and should eventually be made more consistent. The syntax for how to specify a shift should be the same regardless of how an optic is implemented.