mpetroff / pannellum

Pannellum is a lightweight, free, and open source panorama viewer for the web.
https://pannellum.org/
MIT License
4.21k stars 717 forks source link

HotSpot Image Inconsistency (2.3.0) #324

Open milleker opened 7 years ago

milleker commented 7 years ago

When inserting an image in a hot spot, I'm noticing inconsistency with how the hot spot is displayed. The issue seems to happen to new devices or old devices when I clear my cache. The issue happens when the hot spot window will place itself centered over the hot spot icon. On Windows machines, the display issue is just a mere inconvenience, but on touch devices this is a big problem because if there's a link, it automatically sends the user to the link instead of showing the window and letting them click again for the link.

Pannellum 2.3.0 - clean installation, happens on Chrome (Latest) for Windows and Firefox (Latest) on Android. Hotspot section of JSON is below. Happens on Multires or Equirectangular. No console messages.

Screenshot of the problem here: http://www.johnmilleker.com/uploads/hsissue.jpg Test panorama located here: http://www.johnmilleker.com/pannellum/pannellum.htm?config=boam/config.json

    "hotSpots": [
        {
             "pitch": 11.355826084776798,
             "yaw": -91.0605335701549,
             "type": "info",
             "image": "boam_hs_01.jpg",
             "text": "Test Hotspot",
             "URL": "http://www.johnmilleker.com"
        }
    ]
mpetroff commented 7 years ago

Image hot spots aren't officially supported. See #122 and #123.

milleker commented 7 years ago

Thanks Matthew. Hopefully it'll be something you may wish to implement and support in the future.

I've been able to hard code the width and margins for the popup which has worked in the meantime.