mpi2 / PhenotypeData

Reorganisation, update, and extend code from PhenotypeArchive
Apache License 2.0
2 stars 5 forks source link

Requirements for All Data table #325

Closed viomunoz closed 4 years ago

viomunoz commented 4 years ago

Start a document to discuss internally requirements for the All Data table results display.

jwgwarren commented 4 years ago

We should discuss this today?

viomunoz commented 4 years ago

All Data table – points to get conversation going / started

See some screenshots at the end of this document.

How can we best communicate a significant vs a non-significant result?

Statistical test conducted is relevant

Important for users to see sample size (make own assessment of strength of results / evidence)

Background strain is important

In downloadable file, might be useful for users to have the following reported in separate columns:


Screenshot 2020-03-18 at 18.46.55.png

Screenshot 2020-03-18 at 18.52.34.png

Screenshot 2020-03-18 at 18.58.20.png

viomunoz commented 4 years ago

[Apologies for the indentation, this was the best way I could come up with...]

Team met and agreed:

We should show all parameters

What are the columns that we should use in this table?

  1. Allele
  2. Center
  3. Procedure / Parameter
  4. Life stage
  5. Zygosity
  6. Significant (Significant, Not significant, Unable to process, Supplied)
  7. P-value (this is the most significant overall null test p-value)
  8. Phenotype (MP term) 8.1. For (adult and embryo) viability records, when not significant, use the word “Viable” 8.2. For fertility records, when not significant, use the word “Fertile” 8.3. When different for male and female, show both comma separated

On click - depends on data type represented in the row

  1. Images - clicking the row links to the image comparator for that image type
  2. Continuous / Categorical
  3. Time series
  4. Line levels 4.1. Viability 4.2. Fertility 4.3. Embryo viability 4.4. Embryo gross morphology
  5. Ontology 5.1. Adult Gross pathology 5.1.1. Working as expected 5.1.2. Row will either be “Not significant” or “Significant” 5.2. Adult Histopathology 5.2.1. Collapse parameters together by tissue 5.2.2. If any “significance score” is set to true for any specimen*tissue, Significant is true 5.2.3. Clicking on the row links to the histopath table filtered for that tissue

Download link:

  1. Gene
  2. Allele
  3. Center
  4. Pipeline
  5. Procedure
  6. Parameter
  7. Life stage
  8. Zygosity
  9. Significant (Significant, Not significant, Unable to process, Supplied)
  10. P-value
  11. Male p-value
  12. Female p-value
  13. Phenotype male (MP term)
  14. Phenotype female (MP term)
  15. Background strain
  16. Number of mutant males
  17. Number of mutant females
  18. Total mutant number
  19. Number of control males
  20. Number of control females
  21. Total control number
  22. Statistical test
  23. Status (Success, Failed - Low N, etc.)
  24. Metadata group
hughbedo commented 4 years ago

Adding my comments here about the Late adult heatmap -> Gene page link., a little more general than the "All Data Table".

Just my thoughts, it looks really good.

viomunoz commented 4 years ago

See ticket Fertility data not visible #62 for a solution when there is no available data to display.

jmason-ebi commented 4 years ago

Will discuss with NIH UX expert Thursday at 3BST.

viomunoz commented 4 years ago

To consider:

  1. A button that filters to show only signifciant results will most likely be a useful additon -- currently you can filter for physiological systems with significant results, which is useful, but still a lot of data that a user looking for signficant results is not be interested in.
  2. A user commented that pagination and the wrangling of columns is cumbersome -- consider moving the All Data table to a new page.
  3. Also it was noticed that the table doesn't fit horizontally on the screen (1920x1080, chrome, firefox). A horizontal scrollbar appears, but the table header and the scrollbar are not visible at the same time, so scrolling up and down is required.

We can have new tickets for this, here to consider.

viomunoz commented 4 years ago

Closed and replaced by tickets #369, #370, #371, #372.