search

mpociot / captainhook

Add Webhooks to your Laravel app, arrr
335 stars 26 forks source link

Rearrange Guzzle requirement #39

Closed Jeroen-G closed 8 years ago

Jeroen-G commented 8 years ago

It is used outside the tests, so I thought it should also be a 'normal' requirement rather than a dev one. Addresses also #35.

codecov-io commented 8 years ago

Current coverage is 65.68% (diff: 100%)

Merging #39 into master will not change coverage

@@             master        #39   diff @@
==========================================
  Files            11         11          
  Lines           271        271          
  Methods          42         42          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            178        178          
  Misses           93         93          
  Partials          0          0

Powered by Codecov. Last update 8ff6ace...bf78ba9

mpociot commented 8 years ago

Hi @Jeroen-G ,

is there a specific reason, why you removed Guzzle 5.3 as a possible requirement?

Jeroen-G commented 8 years ago

Because of this comment in #35: This can be resolved by either dropping support for 5.3 in your composer.json file, or refactoring your usage of the Middleware class to be compliant with 5.3 and 6.

mpociot commented 8 years ago

ugh...sorry, should've seen that in the first place! Thank you for the PR ❤️