mpv-player / mpv-build

🔨 Helper scripts to compile mpv on Linux
http://mpv.io
414 stars 108 forks source link

--enable-libmpv-shared in mpv_options not working #134

Closed ozmartian closed 1 year ago

ozmartian commented 4 years ago

Maybe i am doing something wrong but I only noticed recently that libmpv.so was no longer building using my mpv-build stack of scripts. Hasn't worked for a month or two now. Thx for all your work and help throughout the years guys!

this is when using mpv-master. release seems to work fine last time i checked. thx!

aerdnar commented 4 years ago

--enable-libmpv-shared depends on ffmpeg_options and /mpv_build/mpv/build/config.log can help. For example on raspbian there is some bug with echo --enable-mmal >> ffmpeg_options in 0.32.0 release due to /mpv_build/ffmpeg_build/libavcodec/libavcodec.pc which not include this flag -L/opt/vc/lib in Libs/Libs.private (you can edit it and launch ./build again not ./rebuild) and /mpv/wscript cannot find -lmmal* library (that was my case) when it checks ffmpeg/libav by compiling a file with /mpv_build/ffmpeg_build/libavcodec/libavcodec.pc/Libs flags as you can see here: https://github.com/mpv-player/mpv/commit/7d11eda72e90d7aa9df25127bd810aa7b191029c#diff-b79856260b3cc9b3e958c83a55bae1e46e31d232125b925c581022786a7bc042L479 row #479 In mpv/master this bug is still here but depends on ffmpeg: in ffmpeg/configure they should change about enabled mmal (row 6467)

add_ldflags -L/opt/vc/lib/ &&
check_lib mmal interface/mmal/mmal.h mmal_port_connect -lmmal_core -lmmal_util -lmmal_vc_client -lbcm_host; }

with

add_ldflags -L/opt/vc/lib/ &&
check_lib mmal interface/mmal/mmal.h mmal_port_connect -lmmal_core -lmmal_util -lmmal_vc_client -lbcm_host &&
prepend mmal_extralibs "-L/opt/vc/lib"; }

but their way to report bug requires git That's bug is not related with your but maybe can help someone.

ozmartian commented 3 years ago

checked /mpv_build/mpv/build/config.log and see the following:

Checking for OpenGL without platform-specific code (e.g. for libmpv)
libmpv-shared not found

my mpv_options are:

--prefix=/usr/local
--disable-static-build
--enable-libmpv-shared
--disable-oss-audio
--disable-alsa
--disable-debug-build
--enable-cplugins

i even tried forcing --enable-libmpv-shared in scripts/mpv-config but no luck :-(

ozmartian commented 3 years ago

did some more testing and got it working by manually building from ./mpv/ folder passing the option on the command line. seems to be ignored from my mpv_options file for some reason.

./waf --enable-libmpv-shared configure
./waf --enable-libmpv-shared install

not sure why it ain't working as it should though

Dudemanguy commented 1 year ago

waf support no longer exists of course but -Dlibmpv=true in mpv_options should work.