Closed mlindner closed 3 weeks ago
--osd-bar-border-size
--osd-bar-border-size
Yes I realize there's an option to change it. I'm asking why it changed. This is a regression.
It was changed because it looks better.
It was changed because it looks better.
Can you point to the commit/line that was changed? I want to know the manner of the change so I can precisely revert it.
And no it doesn't look better. The bar border size is practically invisible now because it is so thin. The border exists for a reason, so that the OSD doesn't blend into the background on white images. Try viewing it from a good distance away on a 4k TV.
https://github.com/mpv-player/mpv/pull/12959 https://github.com/mpv-player/mpv/pull/12994
It looks better because the previous default was hideously thick. Most videos aren't white and even then you can still see the border just fine. Either way the option exists so you can customize it.
12959 #12994
It looks better because the previous default was hideously thick. Most videos aren't white and even then you can still see the border just fine. Either way the option exists so you can customize it.
What was the purpose of the float dent = MPMAX(border * 1.3, 1.6);
change? Or rather, in detail, what is that doing?
Also, thank you, I set the value to 1 which seems to be a good match for the OSD and stats border thickness.
Also, I really suggest watching on a 4k tv, sat a good distance away from you, especially if you're somewhat nearsighted. It doesn't look good at all. It just looks like it's almost gone.
dent is the size of chapter markers and is proportional to the border. Giving them a minimum value makes them clearly visible even with a smaller border.
It shouldn't be an issue here. Post the discussion instead.
mpv Information
Other Information
Reproduction Steps
Use on a 4k window. Use --no-config and change the volume level or seek. Observe that the border around the drawn OSD is much thinner than it used to be.
Expected Behavior
The bar should look something like:![Untitled](https://github.com/mpv-player/mpv/assets/2280117/e29b6f1b-8367-4cbe-9613-61ee2fe19711)
Actual Behavior
Instead it looks like:![mpv-shot0006](https://github.com/mpv-player/mpv/assets/2280117/657863c7-c8a4-4d31-85fc-2ab86d0c2f4a)
Log File
Not sure what log file would demonstrate this.
Sample Files
No response
I carefully read all instruction and confirm that I did the following:
--log-file=output.txt
.