search

mpv-player / mpv

🎥 Command line video player
https://mpv.io
Other
28.78k stars 2.93k forks source link

frame-step plays audio #6104

Open Qwerty-Space opened 6 years ago

Qwerty-Space commented 6 years ago

mpv version and platform

Windows, not sure what version: image

Reproduction steps

Hold down frame-step key

Expected behavior

Cycle through frames

Actual behavior

It pretty much just plays the video, audio and all. Sound should be muted when using this button

Log file

https://b.va-online.moe/uzapuqusem.hs

garoto commented 6 years ago

@Qwerty-Space commented on Sep 2, 2018, 7:49 PM GMT-3:

mpv version and platform

Windows, not sure what version:

image

Invoking mpv.exe directly does not spawn its CLI interface. Try a simple mpv --version or, on a worst case scenario, mpv.com --version.

Regarding the audio playing while frame-stepping, @wm4 (RIP) had this to say about a similar issue dealing with frame-stepping: https://github.com/mpv-player/mpv/issues/3476#issuecomment-244064404

I must confess I never really understood his reply 100%, but I took it as "(shit) is really hard to workaround".

haasn commented 6 years ago

FWIW I always thought this was a feature, not a bug?

garoto commented 6 years ago

I always wished for input-ar-rate to be respected while doing frame-step (audio or not was never relevant for me). Sort of a silly request on the surface I imagine, but nowadays I somewhat can see how doing the work to implement any sort of user-requests can bite you in the ass in the future.

I always assumed to myself that wm4 was paranoic about implementing niche requests for some sort of similar reason.

Qwerty-Space commented 6 years ago

Thanks for the input. Would be nice if it muted it though.

avih commented 6 years ago

Thanks for the input. Would be nice if it muted it though.

For you maybe, but not for others. You are aware that the m button mutes, right?

Qwerty-Space commented 6 years ago

For you maybe, but not for others. You are aware that the m button mutes, right?

Yes, maybe there should be a frame-step & hold-mute thing?

Argon- commented 6 years ago

Some commands are executed asynchronously, right? Or more like: they don't necessarily block until their result is in effect. Otherwise a set mute true ; frame-step ; set mute false might work.

(FWIW, I also like it the way it is)

Qwerty-Space commented 6 years ago

Thanks, I'll give it a shot

Akemi commented 5 years ago

resolved with different key binding.

sersorrel commented 2 years ago

fwiw, the suggested solution doesn't seem to work (even when corrected to set mute yes/set mute no), and nor does applying and restoring a "muted" profile to avoid trashing the existing mute setting.

there's a big set of scripts that claim to include muted stepping: https://github.com/oe-d/control I haven't tried it, maybe it works, but it would be nice to be able to have just "stepping forwards doesn't play tiny chunks of audio" without having to add nearly 600 lines of lua that does a bunch of other stuff too, and it looks kinda complicated to split out that feature from the rest of that script...

haasn commented 2 years ago

Yeah I agree it would be a sane feature to implement. Patches welcome etc.