pc-compat (kernel) compatibilty

[lolpowerluke]

if possible, could you make the plugin compatible with the pc-compat package for kernel currently, the only errors the plugin gives is or this one on start, it only gives one of these errors (not both) and it seems like its random which one it gives

[mr-miner1]

what is pc compat?

[lolpowerluke]

kernel: https://github.com/kernel-mod/electron pc-compat: https://github.com/strencher-kernel/pc-compat

[mr-miner1]

i mean you could try to remove the import for the InstalledProduct.jsx and along with that remove all instances of it.

quick actions won't work though

replacing the index.js file with the code below should do the above.

/* eslint-disable */
const { Plugin } = require("powercord/entities");
const { inject, uninject } = require("powercord/injector");
const {
  React,
  getModule,
  i18n: { Messages },
} = require("powercord/webpack");
// const InstalledProduct = require("../pc-moduleManager/components/parts/InstalledProduct.jsx");
const Settings = require("../pc-settings/index.js");
const { open: openModal } = require("powercord/modal");

const PluginSettings = require("./components/Settings");
const SearchTextbox = require("./components/SearchTextbox");

const DisabledUtil = require("./util/DisabledUtil");
const FavouritesUtil = require("./util/FavouritesUtil");
const SearchUtil = require("./util/SearchUtil");
const CustomContextMenu = require("./util/ContextMenu");
const Customize = require("./util/Customize");
const bd = require("./util/BD-like-settings");
const QuickActions = require("./util/QuickActions");
const ChangeLogModal = require("./components/ChangeLog");

module.exports = class BetterSettings extends Plugin {
  async startPlugin() {
    this.loadStylesheet("./index.scss");
    powercord.api.settings.registerSettings(this.entityID, {
      category: this.entityID,
      label: this.manifest.name,
      render: PluginSettings,
    });

    const log = (...args) => {
      // console.log("[BetterSettings]", ...args);
    };

    const SettingsView = await getModule(
      (m) => m.displayName === "SettingsView"
    );
    log("[BetterSettings]", "SettingsView");
    log("[BetterSettings]", SettingsView.prototype);
    const settingsModule = await getModule(["open", "saveAccountChanges"]);
    let lastsection = {};
    const thisPlugin = this;

    const autoFocus = (autofocus) => {
      setTimeout(() => {
        if (autofocus === true) {
          log("[BetterSettings]", "focusedElem");
          log(
            "[BetterSettings]",
            document.querySelector(
              `[aria-label="USER_SETTINGS"] ${document.activeElement.className}`
            )
          );
          if (
            document.querySelector(
              `[aria-label="USER_SETTINGS"] ${document.activeElement.className}`
            ) !== undefined
          ) {
            document.getElementById("settingssearch").focus();
          }
        }
      }, 1);
    };

    inject(
      "betterSettings_settingsMount",
      SettingsView.prototype,
      "componentDidMount",
      (args, res) => {
        const autofocus = thisPlugin.settings.get("AutoFocus", true);
        autoFocus(autofocus);
        return res;
      }
    );
    inject(
      "betterSettings_settings",
      SettingsView.prototype,
      "render",
      (_, res) => {
        if (res === null) return res;

        log("[BetterSettings]", "Settings.res");
        log("[BetterSettings]", res);

        const sidebarItems = res.props.sidebar.props.children;
        const selectedItem = res.props.sidebar.props.selectedItem;
        log("[BetterSettings]", sidebarItems);
        log("[BetterSettings]", selectedItem);
        log("[BetterSettings]", "lastsection");
        log("[BetterSettings]", lastsection);

        const autofocus = thisPlugin.settings.get("AutoFocus", true);
        const noreset = thisPlugin.settings.get("noreset", false);
        let settings;

        // Push search textbox
        sidebarItems.unshift(
          React.createElement(SearchTextbox, {
            placeholderText: Messages.SEARCH,
            openSettings: settingsModule.open,
            settingsButton: this.settings.get("settings_button", false),
          })
        );

        const sidebarHasItem = (itemName) => {
          return (
            sidebarItems.findIndex((item) => {
              return item.key === itemName;
            }) - 1
          );
        };
        const isUserSettings = sidebarHasItem("changelog") !== -2;
        const isInGuildSettings =
          typeof sidebarItems[1].props.children === "string" && !isUserSettings; // funky!
        const isInChannelSettings =
          typeof sidebarItems[1].props.children !== "string";

        // ID table:
        // 0 - user settings
        // 1 - guild settings
        // 2 - channel settings
        // 3 - gulag
        const sectionID = isUserSettings
          ? 0
          : isInGuildSettings
          ? 1
          : isInChannelSettings
          ? 2
          : 3;

        log("[BetterSettings]", `settingsID: ${sectionID}`);
        log("[BetterSettings]", res);

        settings = document.querySelector(
          `[aria-label="USER_SETTINGS"] .side-2ur1Qk`
        );
        if (document.getElementById("settingssearch") == null) {
          if (noreset === true && lastsection[sectionID]) {
            settingsModule.open(lastsection[sectionID]);
          }
          // autoFocus(autofocus);
          setTimeout(() => {
            settings = document.querySelector(
              `[aria-label="USER_SETTINGS"] .side-2ur1Qk`
            );
            if (settings != null && settings.id !== "checked") {
              SearchUtil.search(
                thisPlugin,
                settingsModule,
                document.querySelector(
                  `[aria-label="USER_SETTINGS"] .side-2ur1Qk`
                ),
                sidebarItems,
                "USER_SETTINGS"
              );
            }
          }, 0);
        }

        // Remember last page (dependant on page)
        if (document.querySelector(`[aria-label="GUILD_SETTINGS"]`) === null) {
          if (res.props.section !== "My Account") {
            lastsection[sectionID] = res.props.section;
          } else if (
            res.props.section !== "OVERVIEW" ||
            res.props.section !== "pc-updater"
          ) {
            lastsection[sectionID] = res.props.section;
          }
        }

        setTimeout(() => {
          settings = document.querySelector(
            `[aria-label="GUILD_SETTINGS"] .side-2ur1Qk`
          );
          if (settings != null && settings.id !== "checked") {
            // autoFocus(autofocus);
            SearchUtil.search(
              thisPlugin,
              settingsModule,
              settings,
              190,
              "GUILD_SETTINGS"
            );
          }
        }, 0);

        return res;
      }
    );

    inject(
      "betterSettings_settingsItems",
      SettingsView.prototype,
      "getPredicateSections",
      (args, items) => {
        // Separate Powercord plugins and give them their own category
        const updaterItem =
          items.findIndex((item) => {
            return item.section === "pc-updater";
          }) + 1;
        const separatePluginsCategory = thisPlugin.settings.get(
          "pluginsCategory",
          false
        );
        console.log(items);
        // refresh plugin on first open because it doesnt get the index for somereason
        if (
          updaterItem === 0 &&
          separatePluginsCategory &&
          items[0].label === "User Settings"
        )
          powercord.pluginManager.remount("better-settings");

        if (separatePluginsCategory && items[0].label === "User Settings") {
          const pcPluginsCategory = [
            { section: "DIVIDER" },
            { section: "HEADER", label: "Plugins" },
          ];

          items.splice(updaterItem, 0, ...pcPluginsCategory);
        }
        return items;
      }
    );
    inject(
      "betterSettings_contextmenu",
      SettingsView.prototype,
      "render",
      (args, res) => {
        const sidebarHasItem = (itemName) => {
          return (
            res.props.sidebar.props.children.findIndex((item) => {
              return item.key === itemName;
            }) - 1
          );
        };
        const isUserSettings = sidebarHasItem("changelog") !== -2;
        if (isUserSettings) {
          CustomContextMenu.create(
            res.props.sidebar.props.children,
            SettingsView,
            thisPlugin,
            settingsModule
          );
          Customize.setColor(res, thisPlugin);
          Customize.setText(res, thisPlugin);
          Customize.setOpacity(res, thisPlugin);
        }
        return res;
      }
    );
    inject(
      "betterSettings_changelog",
      SettingsView.prototype,
      "render",
      (_, res) => {
        if (this.settings.get("changelog", false)) {
          this.settings.delete("changelog");
        } else if (this.settings.get("changelogV1:5", false)) {
          this.settings.delete("changelogV1:5", true);
        }
        if (
          !this.settings.get("changelogV1:6", false) &&
          this.settings.get("show_changelogs", true)
        ) {
          this.settings.set("changelogV1:6", true);
          openModal(ChangeLogModal);
        }
        return res;
      }
    );
    inject(
      "betterSettings_favorites_disabled",
      SettingsView.prototype,
      "render",
      (_, res) => {
        FavouritesUtil.favourites(thisPlugin, res);
        DisabledUtil.disabled(thisPlugin, res);
        return res;
      },
      false
    );
  }
  pluginWillUnload() {
    let injected_elements = [
      "betterSettings_settings",
      "betterSettings_settingsItems",
      "betterSettings_settingsMount",
      "betterSettings_contextmenu",
      "betterSettings_productRenderPrePatch",
      "betterSettings_productRenderPatch",
      "betterSettings_productRenderFooterPatch",
      "betterSettings_makeSectionPatch",
      "betterSettings_getPredicateSectionsPatch",
      "betterSettings_openSettings",
      "betterSettings_quickActionsButtons",
      "betterSettings_quickActionsStart",
      "betterSettings_changelog",
      "betterSettings_favorites_disabled",
    ];
    for (let injected_element of injected_elements) {
      uninject(injected_element);
    }
    powercord.api.settings.unregisterSettings(this.entityID);
  }
};

[lolpowerluke]

it gives this as error now

[mr-miner1]

try removing line 10 ("const Settings = require("../pc-settings/index.js");")

[lolpowerluke]

gives this now

[lolpowerluke]

is there supposed to be a divider.jsx file here? (the components folder in the plugin)

[mr-miner1]

there is not supposed to be. the divider components are being imported from the powercord components module

[lolpowerluke]

I searched for a divider.jsx file, but all I could find was a divider.tsx, could this have anything to do with it?

[mr-miner1]

you could try to remove these 2 lines too, but if it still doesnt work then thats that, i do not plan to support pc-compat.

[lolpowerluke]

yep, works now, thx, also the quick actions not working doesnt really matter for me since pc-compat adds these