search

mraichelson / cyberpunk-red-tabbed

A character sheet for players of Cyberpunk Red that use Roll20.
4 stars 6 forks source link

role_solo_precisionattack_calc not used in attack rolls #34

Closed Harryc6 closed 3 years ago

Harryc6 commented 3 years ago

image Enter as many points into Precision Attack to make sure you see the change. image Then roll attack on any weapon. image image

Potential fix - add text to say it needs to be tracked manually, or add @{role_solo_precisionattack_calc} to the attack roll (not too sure if that would throw a null if not init on character sheet, not familiar with roll20 variables)

mraichelson commented 3 years ago

This has been merged and will be included with the next update submitted to Roll20.

(Sorry for the confusion on my part about pushing changes to the PR around the hidden field, things got...weird.)

mraichelson commented 3 years ago

Included in the PR here: https://github.com/Roll20/roll20-character-sheets/pull/8197

My guess is that this will be checked as part of their monday morning review next week and then possibly make it to production towards the end of next week.