search

mrayson / iwaves

Internal wave equation solvers (KdV, normal modes, TG)
Other
6 stars 7 forks source link

fit_bmodes_nonlinear bug #7

Open ghost opened 2 years ago

ghost commented 2 years ago

The argument given in the function call is "mode", but referenced on line 222 as "modes".

ghost commented 2 years ago

actually a few bugs. Will do a PR when I get around to it.

For future Chris (or Matt if I forget).

  1. Doesn't iterate through modes so either need to add that or remove line 222 (def nmodes)
  2. line 275: rhofitnl = rhoprfit + rhobar[np.newaxis,:] , rhobar should be rhoz
  3. In lines 246 and 251, "Z"s should be "z"
mrayson commented 2 years ago

PRs welcome!

On Tue, May 31, 2022 at 9:12 AM chriswhitwell @.***> wrote:

actually a few bugs. Will do a PR when I get around to it.

For future Chris (or Matt if I forget).

  1. Doesn't iterate through modes so either need to add that or remove line 222 (def nmodes)
  2. line 275: rhofitnl = rhoprfit + rhobar[np.newaxis,:] , rhobar should be rhoz
  3. In lines 246 and 251, "Z"s should be "z"

— Reply to this email directly, view it on GitHub https://github.com/mrayson/iwaves/issues/7#issuecomment-1141573211, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC73RFDK6ZT3FGU2MJDG5G3VMVRRNANCNFSM5XL4TKOQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Matt Rayson

Research Fellow Australian Research Council Industrial Transformation Research Hub for Offshore Floating Facilities Oceans Graduate School and the UWA Oceans Institute University of Western Australia

Ph: +61 8 6488 3083