search

mrbungle73 / editor-on-fire

Automatically exported from code.google.com/p/editor-on-fire
Other
0 stars 0 forks source link

Intermittent crash during MIDI import #253

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
When importing this MIDI:
http://www.sendspace.com/file/x2j0zg

EOF crashes while parsing track 2 (BEAT).  Through EOF's logging, it seems as 
if (at least on my computer), the crash occurs parsing byte 714, during the 
allocation of a new EOF_IMPORT_MIDI_EVENT structure in 
eof_midi_import_add_event().  That the call to malloc() would crash seems to 
indicate that there is a buffer overflow somewhere in the MIDI import logic.

As usual, this crash doesn't happen when running through the debugger, making 
it harder to track things down.

Original issue reported on code.google.com by raynebc on 15 May 2011 at 8:35

GoogleCodeExporter commented 9 years ago 
r755 adds the Memwatch source to EOF to help track down memory leaks and 
corruptions.

Original comment by raynebc on 15 May 2011 at 10:13

GoogleCodeExporter commented 9 years ago 
r811 fixed a buffer overflow in INI import.  Since INI import occurs before 
MIDI parsing, it seems quite likely that may have been the cause of this crash. 
 I haven't run into any such crashes that I can remember, so I'll consider this 
fixed until it occurs again.

Original comment by raynebc on 16 Sep 2011 at 8:44