search

mrdondon / xy-vsfilter

Automatically exported from code.google.com/p/xy-vsfilter
0 stars 0 forks source link

MPC-HC based media players prevent XySubFilter from loading external subtitles #156

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
MPC-BE has code to remove filters without pins from the graph.

This unfortunately causes XySubFilter to be removed from the graph when only 
external and no embedded subtitles exist.

We added a workaround for this same behavior in MPC-HC, but forgot to add 
detection for MPC-BE as well. In the future, we hope both media players will 
add an exception for XySubFilter, so our hackish workaround will no longer be 
needed.

Original issue reported on code.google.com by cyber.sp...@gmail.com on 19 Jul 2013 at 7:39

GoogleCodeExporter commented 8 years ago 
Workaround:

Rename "mpc-be.exe" to "mpc-hc.exe"

Original comment by cyber.sp...@gmail.com on 20 Jul 2013 at 1:58

GoogleCodeExporter commented 8 years ago 
> MPC-BE has code to remove filters without pins from the graph.

Clarification:

MPC-BE & MPC-HC both have code to remove filters without any _connected_ pins 
after graph building has completed.

Original comment by cyber.sp...@gmail.com on 21 Jul 2013 at 10:01

GoogleCodeExporter commented 8 years ago 
Fixed in MPC-BE.

Original comment by Aleksoid...@gmail.com on 23 Jul 2013 at 4:21

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
Thank you, Aleksoid.

Confirmed fixed in MPC-BE build 3087.

Aleksoid has posted a pre-release build at:
http://dev.mpc-next.ru/index.php/topic,1654.msg9236.html#msg9236

MPC-BE commit which resolved this issue:
http://svnlog.mpc-next.ru/comp.php?repname=MPC-BE+Team&compare[]=/@3086&compare[
]=/@3087

Original comment by cyber.sp...@gmail.com on 23 Jul 2013 at 4:48

GoogleCodeExporter commented 8 years ago 
We've been informed by a user the MPC-HC has intermittently been preventing 
XySubFilter from entering the graph for external subtitles on Windows 8, even 
with our MPC-HC workaround in XySubFilter 3.1.0.546 active.

We've made a request that MPC-HC add also add exception for XySubFilter in this 
"no connected pin" removal code. We suspect this will resolve any issues users 
may have been having with external subtitles not loading in MPC-HC.

Original comment by cyber.sp...@gmail.com on 24 Jul 2013 at 1:24

GoogleCodeExporter commented 8 years ago 
Fixed in the following MPC-HC 1.7.0.7649 commit:
http://github.com/mpc-hc/mpc-hc/commit/da795f5034db9be708686435395b681de73f6cdb

Original comment by cyber.sp...@gmail.com on 26 Jul 2013 at 2:17