search

mrene / minidsp-rs

MiniDSP Controller
http://minidsp-rs.pages.dev
Apache License 2.0
113 stars 15 forks source link

Implement cors headers. #573

Closed kettenbach-it closed 1 year ago

kettenbach-it commented 1 year ago

Closes #571

mrene commented 1 year ago

Thanks for the PR!

Could you make this an optional configuration option, along with the hostnames to enable? Having CORS wide opened like this basically opens it up to any website on the internet, which the app should not be doing in its default configuration.

kettenbach-it commented 1 year ago

See my comment here: https://github.com/mrene/minidsp-rs/issues/571#issuecomment-1529514707

PR are to discuss code, not features

mrene commented 1 year ago

Implemented in 838c4a0