search

mrh0 / createaddition

Create Crafts & Additions, Addon to the Create mod by the Create Team.
Other
83 stars 111 forks source link

Funnels don't extract from Rolling Mill #767

Open Emythiel opened 6 months ago

Emythiel commented 6 months ago

Describe the bug If you have a rolling mill on a belt with 2 funnels, as shown in the ponder screen, the funnel meant to take items out does nothing. Instead, the result is just stuck inside the rolling mill until you either right click it to take the item out, or remove the exit funnel.

Video showing it: https://www.youtube.com/watch?v=sYmOdCsenZI

To Reproduce

  1. Place a rolling mill on a moving belt with an intake and outtake funnel.
  2. Have an item inserted and processed.
  3. Item does not leave the mill as long as the outtake funnel is there.

Additional context

edit: To add, tested with just Create, CC&A and Fabric API, no other mods.

MrStickyPiston commented 5 months ago

Same issue here on 1.20.1

Jan-DT commented 3 months ago

bump

Jan-DT commented 3 months ago

I thought this was a bug as well, but it might not actually be, though I am not familiar developing with Create.

I tried looking into the source code, as I wanted to try to fix this, when I noticed the funneling happens through DirectBeltInputBehaviour, which is the same method used by Create's mechanical saws. It is even stated in the source code that the exact code was copied from the Create mechanical saw.

Now, the mechanical saw in Create does not actually use funnels! Instead, you place it in between belts, like this: actual setup and after trying this, it actually works, extracting the items onto the belt like you would expect!

Turns out it is actually the pondering animation which is wrong. Instead of using funnels, you need to place it in between belts like you would with the mechanical saw.

I hope this helps anyone else running into this issue!