search

mrjmd / pdb

Decoupled Blocks is a Drupal 8 module to simplify integrating javascript frameworks into your site.
https://www.drupal.org/sandbox/mrjmd/2664138
57 stars 14 forks source link

JS / CSS not automatically included from YAML files #11

Closed mrjmd closed 8 years ago

mrjmd commented 8 years ago

Our YAML files for components have sections like this:

add_js:   header:   footer: add_css:   header:   footer:

But right now these don't actually do anything. That's no good.

mark-casias commented 8 years ago

I don't think we need these. These are per instance js / css.. unless we want to define some default layout stuffs.

mrjmd commented 8 years ago

I don't think I follow your comment... these are component-specific js and css includes, which have lots of use cases and are the main way to add css and js to your component in the Drupal 7 version.

The only reason they aren't being used currently is because Angular 2 components are adding their typescript files and css files directly, which is actually problematic for several reasons (we should be compiling typescript into js, Drupal is not aware of these files for cache busting, etc).

So I think this is absolutely needed.

mrjmd commented 8 years ago

This is merged, thanks!