mrjoh3 / c3

c3 HTMLWidget Ploting
39 stars 51 forks source link

c3 height issue #14

Open thomasthomasth opened 5 years ago

thomasthomasth commented 5 years ago

Hi,

When some c3 visualisation is inserted into a shiny page, the height parameter does not seem to work.

I am not sure if its related to this issue but it is slightly difficult to use it right now in large Shiny Applications.

Here is a working minimal example:

library(shiny) library(shinydashboard)

data <- data.frame(a = c(1,2,3,2), b = c(2,3,1,5))

shinyApp( ui = dashboardPage( dashboardHeader(), dashboardSidebar(), dashboardBody( tags$head(tags$style("#plot1{height:100vh !important;}")), tags$head(tags$style("#plot2{height:100vh !important;}")), fluidRow( column(6,c3Output("plot1", "100%", "100%")), column(6,plotOutput("plot2", "100%", "100%"))

)

        )

), server = function(input, output) {

output$plot1 <- renderC3({
data %>%
  c3()
})

output$plot2 <- renderPlot({
  plot(data)
})

} )

mrjoh3 commented 5 years ago

I think you are right on the related issue. The resize interaction between the js library shiny and htmlwidgets had been difficult.

The issue you returned had a couple of work arounds, I will try and implement them and get back to you

thomasthomasth commented 5 years ago

Thanks in advance!