search

mrkipling / maraschino

A front-end for HTPCs
MIT License
424 stars 125 forks source link

Updated jQuery to 1.10.2 #323

Closed gugahoi closed 11 years ago

gugahoi commented 11 years ago

jQuery bumped to 1.10.2 along with all other libraries I could find. Minor modifications were required but everything seemed to be working on my brief tests.

gugahoi commented 11 years ago

@N3MIS15 @mrkipling If you guys have time, could you merge this in if it works? Don't wanna merge it myself and run the risk of overlooking something.

mvanderberg commented 11 years ago

Hello,

Is somebody able to merge this? I tested this, and can't find any issues at this point. (I don't use the camera though...)

Thanks in advance,

best regards, Mark

mrkipling commented 11 years ago

Just some quick notes: I recently upgraded to jQuery 1.9 at work. There are two versions that are being developed simultaneously: the 1.9+ branch, and the 2.0+ branch (as I'm sure you're aware). Basically 2.0+ drops support for shitty browsers like Internet Explorer (and Maraschino doesn't technically support IE, so we could even go with 2.0 if we wanted to - but that's down to whoever wants to do it, if anyone :)

If using 1.9+ (which we are now) and the jQuery Migrate plugin hasn't been added already, it might be worth putting in (it's just 1 extra JS file you need to add):

https://github.com/jquery/jquery-migrate/#readme

Some features of the old jQuery API have been not just deprecated but actually removed, so your options are either (a) go over your jQuery code base and replace the old way of doing things with the new way of doing things, or (b) add the jQuery Migrate plugin and things should still work.

Obviously (a) is the best option but also "meh", especially right now.

What I'm saying is, if the migrate plugin is not included already and you're using 1.9+, please include it. It'll only take a second and will stop things from potentially breaking.

Sorry if I'm telling you guys things that you already know - I'm horribly out of the loop here, this is basically @gugahoi and @N3MIS15 's project now. I'm just the guy that started it. Thought I'd chip in with some advice though!