search

mrkipling / maraschino

A front-end for HTPCs
MIT License
424 stars 125 forks source link

update jquery mobile v1.1.0 -> v1.3.2, fixes issue #327. #328

Closed ikkemaniac closed 11 years ago

ikkemaniac commented 11 years ago

Tested briefly but I did not get any errors.

mvanderberg commented 11 years ago

@ikkemaniac :+1:

Thanks for the help! Everything works as before, except for one small thing.. When controlling XBMC through the mobile interface, a server selection window is visible.

greenshot_2013-10-20_17-09-15

Thanks again!

best regards, Mark

ikkemaniac commented 11 years ago

@mvanderberg This particular problem is because I forgot to update the css file to match v1.3.2 of the js file, my bad guys. This was an easy fix; 6395899aeec9027aecdaf7dffc021767b8639265

But then the popup window failed to show all together. I have a stack-trace of the error but my jQuery knowledge falls short to solve this. For those interested: As of the 1.9.1 version the popup window fails to appear because of code in the mobile.js file. This file has click events for numerous navigation bars. In my particular situation this fails because I have no sabnzb, thus the sabnzb module is not loaded, while mobile.js does contain a click event for a sabnzb element. jQuery fails because it's trying to determine the handlers for ALL click events:

jquery-1.10.2.js L5076
// Determine handlers
handlerQueue = jQuery.event.handlers.call( this, event, handlers );

Deep inside this call it fails.

For now i would like to suggest to downgrade back to jQuery 1.7.1 until this is sorted out. I just did a

git checkout 20069a8 static/js/lib/jquery.js

it seems to work with the upgraded jQuery mobile, but please test on multiple platforms before merging in master.

If anybody needs more info or is unable to reproduce please let me know what I can do to help.

grtz

ikkemaniac commented 11 years ago

sorry guys for making a mess of these pull requests... I was to eager to delete my branch apparently.