search

mrmarkfrench / country-select-js

A quick jQuery-based country picker based on https://github.com/Bluefieldscom/intl-tel-input.git
MIT License
282 stars 105 forks source link

responsiveDropdown option added #64

Closed ghost closed 5 years ago

ghost commented 5 years ago

Hi,

This code refers to #57 and #22 issues. I added the responsiveDropdown option as it is referred into the readme. The option is false by default, unless if the window's width is smaller than 768px (based on Bootstrap's small size). This works with multiple countrySelect if they have different sizes. The .country-list width is set on load then on resize.

This is my first contribution to an open source project and I'm not an expert of Javascript so maybe we'll have to change few things in my code.

Please note that the minified js has not changed

mrmarkfrench commented 5 years ago

So as far as functionality goes, this looks good. Thanks for the contribution!

However, in order to make this actually work for most users, we'll need to minify the JS files into the /build directory, which is where most folks load them from.

If you could please update your pull request with this change, I'd be happy to accept it.

ghost commented 5 years ago

It's OK @mrmarkfrench, I have tested the minified file and everything is OK for me. I let you test also on your side. 👋

mrmarkfrench commented 5 years ago

Looks like there's still a conflict. Did you pull down the most recent version before you minified?

ghost commented 5 years ago

Oops, I didn't fetch the upstream, sorry. Should be good now

mrmarkfrench commented 5 years ago

Thanks for the contribution!