search

mrmarkfrench / country-select-js

A quick jQuery-based country picker based on https://github.com/Bluefieldscom/intl-tel-input.git
MIT License
282 stars 105 forks source link

Add missing units from official iso countries list #81

Closed CyprianSz closed 3 years ago

mrmarkfrench commented 3 years ago

Thanks for finding these missing items. A couple of things need small tweaks before this gets merged, however:

  1. Please sort the new items alphabetically by their 2-letter ISO code, in the same way the existing items on the list are sorted.
  2. Please add the name of the new additions in the predominant local language (Antarctica doesn't need one, but notably the French Southern Territories should have "Terres Australes Françaises"), in the same manner as the other items already in the file.

Also, just as a note, Heard Island and McDonald Islands is a territory that is officially uninhabited, so while for the sake of completeness I'm happy to include it, I do wonder how many people are going to be selecting it. Then again, I don't pretend to know all of the use cases for the plugin, so if somebody is trying to record penguin survey data or something, I'd hate for them to be missing a necessary option...

At any rate, if you could please make the two small adjustments mentioned above, I'd be happy to accept this request and get it merged.

CyprianSz commented 3 years ago

I'm aware of what you mentioned and even have had similar conversation with same arguments, but it finished with conclusion there should be all units from official ISO list. Maybe one day civilization will reach those islands too :)

Ad1. I see that items are sorted alphabetically by names not ISO codes and I've added new ones in this manner. Can you please verify? Ad2. Done.

mrmarkfrench commented 3 years ago

Nope, you're right about the sort order. That's my mistake. I see you added the predominant language part, so this looks good. I'll get this merged momentarily.