search

mrousavy / nitro

🔥 Insanely fast native C++, Swift or Kotlin modules with a statically compiled binding layer to JSI
https://nitro.margelo.com
MIT License
665 stars 22 forks source link

chore: Hoist RN, React, Jest and @types in root #294

Closed chrispader closed 3 weeks ago

chrispader commented 3 weeks ago

Moves explicit package versions to <root>/package.json and only uses * wildcards in workspace packages.

This makes it easier to bump package versions in the future

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nitro-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 8:46pm
mrousavy commented 3 weeks ago

on second thought; could we also use a fixed version (^0.75.2) in example/, but leave it at wildcard (*) for stuff like packages/react-native-nitro-modules where it theoretically doesn't matter which RN version it uses as it is a peer/dev-dependency only?

mrousavy commented 3 weeks ago

It kinda looks weird to have a RN app where it basically says "react-native version whatever *"