mrousavy / react-native-blurhash

🖼️ A library to show colorful blurry placeholders while your content loads.
https://blurha.sh
MIT License
1.92k stars 70 forks source link

[BUG] Blurhash.encode crash in ios 0.75.2 by new architecture #197

Closed llr101 closed 2 weeks ago

llr101 commented 3 weeks ago

Bug

Describe the bug

Blurhash.encode crash in ios 0.75.2 by new architecture

To Reproduce Steps to reproduce the behavior: Blurhash.encode a local image

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

(Optional) Proposed solution If you have an idea on how one might fix this bug, please describe it here.

Environment

Additional context Add any other context or screenshots about the feature request here.

paste the output of `react-native info` here
"react": PASTE_VERSION_HERE,
"react-native": PASTE_VERSION_HERE,
"react-native-blurhash": PASTE_VERSION_HERE
maintenance-hans[bot] commented 3 weeks ago

Guten Tag, Hans here! 🍻

Thanks for reporting ze issue. However, I need more information to help solve it. Please paste ze output of react-native info including versions of React, React Native, and react-native-blurhash. Also, it would be really helpful to see ze logs from Xcode when ze crash happens. This will help mrousavy understand ze problem better.

Looking forward to your reply!

Note: If you think I made a mistake, please ping @mrousavy to take a look.

llr101 commented 3 weeks ago

"react": 18.3.1, "react-native": 0.75.2, "react-native-blurhash": 2.0.3

react native use new architecture

14fb5e779fca64edf0f3620c0928beb7

mrousavy commented 3 weeks ago

maybe that needs to be NSNumber* instead of double

llr101 commented 3 weeks ago

@mrousavy I tried, no crash, but no resolve or reject callback in react native. I can’t get image hash

llr101 commented 3 weeks ago

@mrousavy It seems like codegen generate a file with wrong params name and type. #198