Issue 49 remove exists forall - Githubissues

mrpowers-io / quinn

pyspark methods to enhance developer productivity 📣 👯 🎉

https://mrpowers-io.github.io/quinn/

Apache License 2.0

647 stars 99 forks source link

Issue 49 remove exists forall #233

Closed nijanthanvijayakumar closed 4 months ago

nijanthanvijayakumar commented 4 months ago

Proposed changes

This PR will help close the #49 following changes were made to remove/deprecate the functions exists and forall functions from the codebase.

Remove exists and forall functions from quinn/functions.py.
Remove import statements for exists and forall from quinn/__init__.py.
Remove tests related to exists and forall functions from tests/test_functions.py.

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Further comments

I have tested this in my local and the tests have passed.
Closes the issue #49

nijanthanvijayakumar commented 4 months ago

@SemyonSinchenko - I have created this PR pointing to the planning-1.0 branch. Please let me know your thoughts?

nijanthanvijayakumar commented 4 months ago

@SemyonSinchenko - this PR is related to the issue #49 and closes it, but also partially of the issue #199.

Would be great if you could review this too.