mrpowers-io / quinn

pyspark methods to enhance developer productivity 📣 👯 🎉
https://mrpowers-io.github.io/quinn/
Apache License 2.0
647 stars 99 forks source link

Align ruff versions and apply hotfix #251

Closed fpgmaas closed 4 months ago

fpgmaas commented 4 months ago

Proposed changes

This PR outlines some issues with the use of ruff and provides a solution. However, since that proposes a slightly larger overhaul and might need some discussion and tweaking, this PR proposes to align the versions of ruff specified in the various files. Also, it applies a hotfix to quinn/schema_helpers.py.

Types of changes

What types of changes does your code introduce to quinn? Put an x in the boxes that apply

SemyonSinchenko commented 4 months ago

Let's wait until #244 is merged? Otherwise we will have a merge-conflicts again. Sorry about that: I love productivity, but I was not ready for such active development and too many PRs in the last days...

fpgmaas commented 4 months ago

Let's wait until #244 is merged? Otherwise we will have a merge-conflicts again. Sorry about that: I love productivity, but I was not ready for such active development and too many PRs in the last days...

Sure, no problem! I will pause my PR's for a bit. Let me know when you're ready for new PR's.

SemyonSinchenko commented 4 months ago

@fpgmaas If you resolve the conflicts, I will merge this one. And after that we may merge #248

fpgmaas commented 4 months ago

@SemyonSinchenko rebased :)