Add mrpt_rbpf_slam, mrpt_icp_slam_2d, mrpt_ekf_slam_3d, mrpt_ekf_slam_2d packages.

mrpt-ros-pkg / mrpt_slam

ROS wrappers for SLAM algorithms in MRPT

http://wiki.ros.org/mrpt_slam

BSD 3-Clause "New" or "Revised" License

114 stars 49 forks source link

Closed Logrus closed 8 years ago

Logrus commented 8 years ago

This pull request is a part of the GSoC project "ROS packages for versatile RBPF-based SLAM", for more information see https://github.com/MRPT/GSoC2016-discussions/issues/3.

jlblancoc commented 8 years ago

I'll need a bit more time to examine all the changes in this one, but I'm pretty sure it'll be ok since you did a great work all this time ;-)

After merging, I'll start doing the PR to rosdistro, etc. so the ROS documentation wikis start to get updated...

jlblancoc commented 8 years ago

Hi Vlad, More details: the destructor of base classes should be virtual (e.g. in ~EKFslam, etc.) to be 100% safe in all cases, see for example: http://stackoverflow.com/questions/5873515/why-should-the-destructor-of-base-classes-be-virtual