search

mrsauravsahu / kube-homelab

A Kubernetes based homelab for everyone! ARM first supported! [WIP - expect breaking changes]
https://www.youtube.com/playlist?list=PLS1J2nE4S3DMyOwA7IPoHQV_FNsFikwC2
33 stars 3 forks source link

Fix: Deploy ingress controller daemonset only on pi node #106

Closed mrsauravsahu closed 2 months ago

mrsauravsahu commented 2 months ago

pi5 is failing ingress-nginx - since I am using only pi as ingress, no need to have the controller deployed to both nodes anyway for now - using nodeSelector to only deploy to pi

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

Walkthrough

The update involves configuration adjustments in the ingress-nginx chart. A nodeSelector has been introduced to specify the nodes where the controller should run, enhancing deployment specificity and resource efficiency. Additionally, enableAnnotationValidations has been set to false, simplifying the annotation process by reducing validation strictness.

Changes

File Path Change Summary
.../ingress-nginx/values.yaml Added nodeSelector under controller with a node label requirement; set enableAnnotationValidations to false.

🐇✨ In the garden of code, where the data trees grow, A tiny change here, a tweak in the flow. With labels aligned, and validations at rest, Our nginx sails smoothly, on its Kubernetes quest! 🌟🌿

Recent Review Details **Configuration used: CodeRabbit UI**
Commits Files that changed from the base of the PR and between e82fc49d76ff0c03593b30ee7a75de6b0a5639c5 and 3706946dc95c490894f44c6136e4480ff9dc8255.
Files selected for processing (1) * molecules/cluster-resources/config/externals/ingress-nginx/values.yaml (1 hunks)
Additional comments not posted (2)
molecules/cluster-resources/config/externals/ingress-nginx/values.yaml (2)
`20-21`: Ensure that all nodes intended for ingress-nginx deployment are correctly labeled with `kubernetes.io/hostname: pi` to match the `nodeSelector` configuration. --- `21-21`: Clarify the rationale for setting `enableAnnotationValidations` to `false`. This setting disables validation of ingress annotations, which could impact the security or functionality of the ingress rules.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.