mrtazz / restclient-cpp

C++ client for making HTTP/REST requests
http://code.mrtazz.com/restclient-cpp/
MIT License
1.57k stars 377 forks source link

These two lines allow the scope of the property <target> for the public #156

Closed Vi1i closed 4 years ago

Vi1i commented 4 years ago

Headers to be available when making use of the add_subdirectory from a parent project.

This will allow other add_subdirectory's to reference the headers during the build process of cmake within target_include_directories.

This would make issues like #130 easier to do for cmake users. This change also moves the file towards CMake standards.

I can give a more detailed explanation if needed. I can do more cleanup if needed as well. I noticed there aren't tests for installation of files, not sure if that is something interested in or expected. Can do if needed for idempotent issues for changes like this.

Checklist

Not all of these might apply to your change but the more you are able to check the easier it will be to get your contribution merged.

Vi1i commented 4 years ago

I do not think the build failures here are on me, let me know otherwise.

edwinpjacques commented 4 years ago

Hi @Vi1i I fixed the CI, can you please rebase and see if we can get this change merged? Thanks.