search

mscdex / connect-busboy

Connect middleware for busboy
MIT License
155 stars 25 forks source link

Add troubleshooting section to README.md #2

Closed markstos closed 9 years ago

markstos commented 10 years ago

Explains what might cause req.busboy to be undefined.

markstos commented 10 years ago

I've updated the pull request to address your feedback.

markstos commented 9 years ago

Is there any further feedback on this pull request since I updated about 10 months ago?

markstos commented 9 years ago

@mscdex You are right the third point should only apply to be ill-behaved clients. My recommendation is still include it for completeness, but mention that it is the least likely option. I've updated the proposed text here:

https://github.com/markstos/connect-busboy/blob/master/README.md#troubleshooting

markstos commented 9 years ago

Thanks for catching that. The typo has been fixed.

mscdex commented 9 years ago

LGTM. Can you please squash the commits?

markstos commented 9 years ago

It's now been squashed and rebased on to the current master.

mscdex commented 9 years ago

Landed in b888fcaabe. Thanks!