search

mscdex / node-ftp

An FTP client module for node.js
MIT License
1.13k stars 246 forks source link

FIXED: use Buffer.from(string) instead of Buffer(string) #230

Open warpdesign opened 5 years ago

warpdesign commented 5 years ago

Fixes Node.js 10 deprecated warning, see: https://nodejs.org/api/buffer.html#buffer_new_buffer_string_encoding

jasonwilliams commented 2 years ago

@mscdex are you able to merge this?

mgrist commented 1 year ago

Someone please merge this... I really need to use this library and this error is preventing me from doing so.

jasonwilliams commented 1 year ago

Someone please merge this... I really need to use this library and this error is preventing me from doing so.

I’m pretty sure this library is dead, https://github.com/mscdex/node-ftp/issues/277

mgrist commented 1 year ago

Someone please merge this... I really need to use this library and this error is preventing me from doing so.

I’m pretty sure this library is dead, #277

Yeah, I thought so. Thanks for the heads up. Ended up using a different library.

pedro-w commented 1 year ago

@mgrist as a matter of interest, which library are you using now?

mgrist commented 1 year ago

@mgrist as a matter of interest, which library are you using now?

I ended up using basic-ftp. It was really easy to use and seems to have regular updates to the repository. I mainly needed an FTP library that could work with streams. If you have any questions just let me know.