Improved connection handling

[coveralls]

Coverage increased (+18.7%) to 89.928% when pulling 475fcd437df3ec2c66234917e419fad9c0dcb5e9 on mschae/connections into 4077c6cb858df4e9de8f27cd0024b6638a543934 on master.

[coveralls]

Coverage increased (+18.7%) to 89.928% when pulling 6b31b00c4d6b2b827e4dc40c0ee556ed84405346 on mschae/connections into 4077c6cb858df4e9de8f27cd0024b6638a543934 on master.

[coveralls]

Coverage increased (+25.2%) to 96.46% when pulling 8f086fb0705093d0d11856e7e0e237af3eaf220d on mschae/connections into 4077c6cb858df4e9de8f27cd0024b6638a543934 on master.

[florinpatrascu]

Hi @mschae - I see what breaks my stuff here :) You're returning now [{:success, %{..} | {:success, %{...}], rather than a list of "successes": [{:success, %{..}, {:success, %{...}], as it used to be. On my side I am collecting every type of :success (a very important aspect!) with Keyword.get_values/2, which obviously does't apply anymore. Before looking into changing the way I collect the :success values, what is your plan for this? Thank you!

[mschae]

God damn it. Sorry, I messed up wrapping that list. My intention was to keep returning a list and hopefully that's now what I do.

TFW you add tests but they are worthless 😞

[coveralls]

Coverage increased (+26.1%) to 97.368% when pulling a223d0aa1869fbc85d06d8fc911c5ad5f35ba053 on mschae/connections into 4077c6cb858df4e9de8f27cd0024b6638a543934 on master.

[florinpatrascu]

Gooooooddddd Morning (well... GMT-5) :) Yes Sireeee, this is working niceeee! Ran the integration tests quickly, before getting late for work, and they are all green!! yay! Thank you, Michael! Let me know if this is the branch we want to support from now on, and I'll merge it to Bolt.Sips master and try to push it in the afternoon (tho' I have a bug reported by @vic, which I need to get to it before that - not related to this branch, I think?!). Once again, thanks man, this looks nice! 🍻

[florinpatrascu]

Hey @mschae - when you find a bit of time, please let me know if this branch can be merged to the master and I'll start integrating it in bolt_sips right away. Thank you!

[mschae]

Sorry for the delay, I'll get to it this weekend. Should also help with the issue you CCed me on regarding non-encodable entities.

[florinpatrascu]

Thank you so much for the quick reply, Michael. Indeed the suppport for the non-encodable entities is another advantage of this version :) I'll start integrating in a bit. Have a great day!

[florinpatrascu]

all green!

🍻

[mschae]

@florinpatrascu v0.3.0 released (technically the run_statement change is backwards incompatible).

Feel free to merge and release, also please let me know if this fixes florinpatrascu/bolt_sips#17 (if not I will make sure to quickly add better messages).