Closed florinpatrascu closed 6 years ago
Hi Michael - I am implementing the bolt+routing protocol which requires a lot of changes from my side, including the ability to decide the type of connection used, based on the protocol. However, there are different methods used for obtaining the routing table from the server, and those are dependent on the server info. Boltex is "hiding" that info, in the init, which is what I am trying to address with this PR. Please have a look, when you have time. Thank you - Florin
Hey Florin,
Super sorry for the late reply. I’m on paternity leave right now and completely lost touch with the outside world. :)
I’ll merge this hopefully today and release a new version.
Sorry again, Michael
-- Michael Schaefermeyer michael.schaefermeyer@gmail.com DE phone +49 (251) 590 8787 <//+49 (251) 590 8787> US phone +1 (415) 439 0430 <//+1 (415) 439 0430> about.me/mschae
Am 13. November 2017 um 20:42:11, Florin (notifications@github.com) schrieb:
Hi Michael - I am implementing the bolt+routing protocol which requires a lot of changes from my side, including the ability to decide the type of connection used, based on the protocol. However, there are different methods used for obtaining the routing table from the server, and those are depending on the server info. Boltex is "hiding" that info, in the init, which is what I am trying to address with this PR. Please have a look, when you have time. Thank you - Florin
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mschae/boltex/pull/20#issuecomment-344034359, or mute the thread https://github.com/notifications/unsubscribe-auth/AAc4mcdYYCWMbeFvIhea2AMQkfgKWqouks5s2JuTgaJpZM4QcTEO .
Oh, no worries Michael!!! Take your time, and congratulations!!!! :)
Thanks again @florinpatrascu 0.4.0 was just released to hex. Sorry for the delay, the chaos normalizes here and I hope to get back to my laptop more regularly now.
Thank you, @mschae!!! Take care :)
Coverage remained the same at 97.368% when pulling 14675df3903b46791e88e96b446fd025f26aa31f on florinpatrascu:init_with_server_info into 63b0fa47d5517e782272f7469856c5cad97249b6 on mschae:master.