search

mschae / boltex

Elixir driver for the neo4j bolt protocol
Other
29 stars 6 forks source link

Bolt v3 #27

Open dominique-vassard opened 5 years ago

dominique-vassard commented 5 years ago

Hi @mschae I've implemented Bolt V3. (Issues #26)

I think though that a refactoring will be needed, the 3 versions and mixed in all files and it's hard to understand how a version is different from another. It relies on doc and on the fact that user knows what he's doing. Not really the best, and in fact the code is not self explanatory anymore. Before tackling this issue, I wait to know what's going on with the bolt_sips - boltex separation: 2 projects or 1?

Thank you

coveralls commented 5 years ago

Coverage Status

Coverage increased (+1.1%) to 96.335% when pulling 347d7006530d1c503ba86bde4006f86dedd1d648 on dominique-vassard:bolt_v3 into acf71d9c97782d17ad9c07f7ea2a7e7f12dbb311 on mschae:master.

dominique-vassard commented 5 years ago

Finally everything is green :)

mschae commented 5 years ago

So sorry for dropping the ball here, is this good to merge?