search

msgpack / msgpack-c

MessagePack implementation for C and C++ / msgpack.org[C/C++]
Other
3.03k stars 883 forks source link

Minimall supported build without boost. #1001

Closed redboltz closed 2 years ago

redboltz commented 2 years ago

To remove boost dependency, -DMSGPACK_USE_BOOST=OFF for cmake. By default, -DMSGPACK_USE_BOOST is ON. NOTE: In order to build tests -DMSGPACK_USE_BOOST=ON is required.

For C++ compiler, the option -DMSGPACK_NO_BOOST is required to remove boost.

codecov-commenter commented 2 years ago

Codecov Report

Merging #1001 (9e14be5) into cpp_master (59f2da6) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 9e14be5 differs from pull request most recent head 066d509. Consider uploading reports for the commit 066d509 to get more accurate results

@@             Coverage Diff             @@
##           cpp_master    #1001   +/-   ##
===========================================
  Coverage       85.56%   85.56%           
===========================================
  Files              79       79           
  Lines            5009     5009           
===========================================
  Hits             4286     4286           
  Misses            723      723
holmesconan commented 2 years ago

It seem the no boost here is not done? include/msgpack/v1/adaptor/cpp11/chrono.hpp still contains boost headers.

redboltz commented 2 years ago

See #1006 . It seems that no additional commit is pushed yet.