msgpack / msgpack-javascript

@msgpack/msgpack - MessagePack for JavaScript / msgpack.org[JavaScript/TypeScript/ECMA-262]
https://msgpack.org/
ISC License
1.3k stars 162 forks source link

avoid using typescript-specific language extensions (const enum) #217

Closed gfx closed 2 years ago

gfx commented 2 years ago

Rationale: https://github.com/tc39/proposal-type-annotations#omitted-typescript-specific-features-that-generate-code

The tc39/proposal-type-annotations is considered a minimum viable subset of the TypeScript language. It would be nicer if TypeScript libraries can follow the spec so that any TypeScript processors can compile them.

codecov-commenter commented 2 years ago

Codecov Report

Base: 98.13% // Head: 98.14% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (7966865) compared to base (b015e94). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #217 +/- ## ======================================= Coverage 98.13% 98.14% ======================================= Files 16 16 Lines 966 969 +3 Branches 206 206 ======================================= + Hits 948 951 +3 Misses 18 18 ``` | [Impacted Files](https://codecov.io/gh/msgpack/msgpack-javascript/pull/217?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=msgpack) | Coverage Δ | | |---|---|---| | [src/Decoder.ts](https://codecov.io/gh/msgpack/msgpack-javascript/pull/217/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=msgpack#diff-c3JjL0RlY29kZXIudHM=) | `99.16% <100.00%> (+<0.01%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=msgpack). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=msgpack)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.