search

msmasnadi / OPGEEv4

OPGEE v4
Other
9 stars 2 forks source link

Revisions to Smart Defaults #11

Open rjplevin opened 1 week ago

rjplevin commented 1 week ago

  1. There are circular dependencies between API and GOR. (See Field.GOR_default() and the comment thereafter in field.py). Currently, there is a smart default method to compute GOR from API gravity, but the reverse (computing API from GOR) is commented out. The current approach of creating a dependency network to determine the order of processing smart defaults does not support cycles.

  2. There is a question about the implementation of method Field.WIR_default(), which sets WIR from WOR. In OPGEEv3, this code added one to the WOR default, which at the time of implementation, was 6. The question is whether WIR should default to 7 or always be WOR + 1 (the latter being what is implemented currently.)

  3. A cryptic comment at the end of field.py says:

    # TODO: decide how to handle "associated gas defaults", which is just global vs CA-LCFS values currently

    Unclear what this means, but it should be explored.

[Seeking input from @wennanlong]

wennanlong commented 4 days ago

This is the future work that will be discussed soon.