mstorsjo / llvm-mingw

An LLVM/Clang/LLD based mingw-w64 toolchain
Other
1.98k stars 188 forks source link

typo in python buildscript #426

Open nullorigin opened 7 months ago

nullorigin commented 7 months ago

Hi, you forgot to put a slash on the line above --fPIC in the configure section of build-python.sh. It is causing a linker error related to python and lldb. Here is a block of code with the correction:

../configure --prefix="$PREFIX" --build=$BUILD --host=$HOST \ CFLAGS="-I$PREFIX/include" CXXFLAGS="-I$PREFIX/include" LDFLAGS="-L$PREFIX/lib -Wl,-s" \ PKG_CONFIG_LIBDIR="$PREFIX/lib/pkgconfig" \ --with-build-python="$NATIVE_PYTHON" \ --enable-shared \ --with-system-ffi \ --without-ensurepip \ --without-c-locale-coercion \ --fPIC

And here is that block of code currently:

../configure --prefix="$PREFIX" --build=$BUILD --host=$HOST \ CFLAGS="-I$PREFIX/include" CXXFLAGS="-I$PREFIX/include" LDFLAGS="-L$PREFIX/lib -Wl,-s" \ PKG_CONFIG_LIBDIR="$PREFIX/lib/pkgconfig" \ --with-build-python="$NATIVE_PYTHON" \ --enable-shared \ --with-system-ffi \ --without-ensurepip \ --without-c-locale-coercion --fPIC

Just thought I should let you know. And I think this project is very handy. So much easier to setup llvm rather than manually compiling it.

EDIT: Even still, if its not there, it needs to be, because of an error that is thrown when linking. The error says something similar to "recompile with -fPIC enabled". It happen's when lldb is linking with python. I'll show you the exact error with context, just give me some time to build your project again without the ==fPIC option in the python build script.

mstorsjo commented 7 months ago

I'm not quite sure what you refer to here - the two blocks of code you quoted are identical, and our build-python.sh script doesn't contain any instance of --fPIC: https://github.com/mstorsjo/llvm-mingw/blob/master/build-python.sh#L149-L156