when scanning a pack via an outbound shipment, data are not transferred over to the stock line details view (View Stock)

msupply-foundation / open-msupply

Open mSupply represents our most recent advancement in the Logistics Management Information System (LMIS), expanding on more than two decades of development inherited from the well-established legacy of the original mSupply.

https://msupply.foundation/open-msupply/

Other

23 stars 14 forks source link

when scanning a pack via an outbound shipment, data are not transferred over to the stock line details view (View Stock) #2947

Open richardmoizeau opened 9 months ago

richardmoizeau commented 9 months ago

What went wrong? 😲

When scanning an item via Outbound Shipment, barcode data (2D Matrix) are not transferred over the stock line details in View Stock.

Expected behaviour 🤔

In case some of the barcode fields (expiry date, batch number, GTIN) are not populated, we would expect to have this information automatically updated when an item is dispensed using barcode scanning in the stock view details view.

How to Reproduce 🔨

Steps to reproduce the behaviour:

See above video.

Your environment 🌱

Version: 1.6.01
Platform: desktop (macOS)

Chris-Petty commented 8 months ago

See above video.

@richardmoizeau Do you still have the video to upload? Or reproduction steps?

richardmoizeau commented 8 months ago

Reproduction steps:

Add an item to an outbound shipment using barcode scanner (must be an item that was never scanned before and ideally must a GS1 2D Matrix (looks like a QR code)
Since barcode is not recognised, system asks you to choose the item from a list
select the item, add quantity (but not all of it) and finalise shipments (status = shipped)
now go to View stock and select the corresponding stockline of the item you just shipped and you can see that GTIN number is not recorded

tagging @mark-prins

mark-prins commented 4 months ago

Confirmed that this is still an issue and can replicate using the steps above. Checking the code: the barcode is added to the barcode table, but existing stock lines aren't modified. To store the barcode as per the issue, we'd need to identify the 'item not found' state and update the barcode column for stocklines of that item_id.

Seems like a reasonable change - not high priority though.