search

msupply-foundation / open-msupply

Open mSupply represents our most recent advancement in the Logistics Management Information System (LMIS), expanding on more than two decades of development inherited from the well-established legacy of the original mSupply.
https://msupply.foundation/open-msupply/
Other
23 stars 14 forks source link

Adding an item to an existing manual requisition results in a blank page #5562

Closed marthakeezy closed 1 day ago

marthakeezy commented 3 days ago

What went wrong? 😲

When adding an item to a manual requisition (General, not Programs), the screen first appears blank and then when navigated away and back to the item, the detailed view appears

Video of the bug ->>> here

Expected behaviour 🤔

The detailed view should be shown straight away

How to Reproduce 🔨

Steps to reproduce the behaviour:

  1. Go to Distribution -> Requisitions
  2. Create a new manual requisition (important - navigate away from it, don't add the item straight away)
  3. When back -> and prompted with choice between Program & General, choose General
  4. Add an item -> see blank screen appear like in the video
  5. Navigate away and back to the item you just added
  6. Detailed view should now appear

Your environment 🌱

roxy-dao commented 3 days ago

To test: throttle network. Probably need to await before navigating away

roxy-dao commented 2 days ago

Closed in #5566

marthakeezy commented 1 day ago

Hi Roxy,

I now see an infinite loading spinner :0 only happening in browser, not on Android

Video here

roxy-dao commented 1 day ago

Will close for now. Saw it was loading but took a long time. Might have been a config problem..? Can reopen if it is actually a performance issue

marthakeezy commented 1 day ago

@npendergrast just suggested a test - because my server is in Amsterdam, and I am running it through the browser in New Zealand, he thought it might be a latency issue (which we have confirmed)

I just tried creating a requisition from the browser from my test server (so Amsterdam to Amsterdam), and the item loaded immediately! And he says it might be a problem since a lot of clients can have their server running from the cloud.

Leaving this in the hands of developers :)

npendergrast commented 1 day ago

Hi @roxy-dao, not sure if this is a problem in the short term, as the OmSupply central might not be used for too much at this stage. But longer term it seems likely that we will have users in countries like Timor/PNG/Fiji etc who are connecting to OmSupply Central from a browser in their country. So latency issues might become more of a problem

Are there a lot of calls and responses to the server for this action?

andreievg commented 1 day ago

We were hoping to postpone dealing with very low latency for web app, since we have sync system. I don't think we will be able to make the web app work when connection is very bad, but we should support our cloud server in Holland (slow, but no infinite loaders)