Closed garygreen closed 9 years ago
Thanks for the PR @garygreen! I agree that it's time to drop the dependency on Illuminate/html because we're not using it for anything complex here. Have you tested this new version with some of the Laravel versions? I will be able to merge and release if you have!
Have tested as working on 4.0, 4.1, 4.2, 5.0
Thanks so much @garygreen! I will release a new tag right now
@msurguy how do you feel about this one? Of course a breaking change so would need a major version bump but I think currently a lot of issues spawn from usage of the
macro
on FormBuilder. These issues range from supporting legacy Laravel < 4.2, newer Laravel >= 4.2.. and now thatilluminate/html
has been deprecated it's been replaced with another package called Laravel Collective which runs under a different namespace but is essentially the newillluminate/html
.That's a lot to support and keep up with when all it's doing is just adding a macro which isn't really worth it imo. Doing
Honeypot::getFormHtml(...)
vsForm::honeypot(...)
isn't really much of a difference.As this is a breaking change, I've also added in this commit a rename of the method
getFormHtml
to simplygenerate
-- it's possibly a nice time to make the change as read's nicer in it's usage:{{ Honeypot::getFormHtml() }} {{ Honeypot::generate() }}
Let me know what you think :smile: