search

msys2 / MINGW-packages

Package scripts for MinGW-w64 targets to build under MSYS2.
https://packages.msys2.org
BSD 3-Clause "New" or "Revised" License
2.27k stars 1.21k forks source link

Add nsis-registry-bin #22000

Open ciros88 opened 2 weeks ago

ciros88 commented 2 weeks ago

Package name

nsis-registry-bin

Brief description of package

https://aur.archlinux.org/packages/nsis-registry-bin

URL for package's homepage

https://aur.archlinux.org/packages/nsis-registry-bin

Provide a basic test case to validate the package's functionality.

https://github.com/aargirakis/BZRPlayer/tree/cmake

MINGW environments where you need the package

Are you willing to submit a PR?

No response

ZachBacon commented 1 week ago

For the record, projects homepage is https://nsis.sourceforge.io/Registry_plug-in Not the aur.

ciros88 commented 1 week ago

I've linked aur entries for having an already made path to follow, and any aur entry already has its proper upstream url

ZachBacon commented 1 week ago

And yet a lot of nsis plugins are just binary redistribution with no source, and the ones you linked are specifically that, repackaged binary distributions. I don't think that's a good candidate to include. But that's my opinion on the matter.

ciros88 commented 1 week ago

my statements still stand, especially if you consider that nsis plugins currently already included in msys2 do not have the *-bin prefix when they should, but the aur entries I proposed (this was part of what I meant with "already made path to follow")

ZachBacon commented 1 week ago

The nsis plugins we provide have source files that we compile. Not precompiled binaries, my statement still stands.

ciros88 commented 1 week ago

The nsis plugins we provide have source files that we compile. Not precompiled binaries

true, i was incorrectly remember.

And yet a lot of nsis plugins are just binary redistribution with no source, and the ones you linked are specifically that, repackaged binary distributions.

So *-bin aur entries i provided still represent good examples to might follow btw

ZachBacon commented 5 days ago

Within the following few weeks, I'll post some of the packages that do contain the source files. But I won't make the packages that only provide the binary files.

ciros88 commented 5 days ago

Thanks. There is a specific reason for avoiding *-bin pkgs?

ZachBacon commented 5 days ago

Thanks. There is a specific reason for avoiding *-bin pkgs?

Primarily for the fact it could introduce runtime incompatibilities for one. Better to have it compiled from source than to have potential conflicts of that nature. You'll find that our packages are all compiled by the native compilers to avoid such issues. There may be some edge cases, but in general it's rare. If you need to have it, download it yourself and put the plugin in the search directory in your mingw share directory.